ExpressRunner 支持线程重入 #155
Merged
ExpressRunner 支持线程重入 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
发现另外一个expressRunner的线程重入的问题，关于计时器reset的问题： QLExpressTimer.reset();这句应该移到InstructionSetRunner.executeOuter()里，只在最外层执行结束后才重置计时器。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #154
修复一直以来有很多人反馈的无法线程重入执行的问题。下文中称线程第一次运行脚本为 “原执行”，在脚本中又重入运行脚本为 “重入执行”。
在线程重入的情况下，重入执行调用的
InstructionSetRunner.executeOuter在返回之前会清空缓存，而且原执行使用的也是同样的缓存，这就导致原执行持有的数据都被清空了，会产生莫名其妙的错误。修复这个问题只需要判断线程重入，改成调用不清空缓存的
InstructionSetRunner.execute方法即可。